-
Notifications
You must be signed in to change notification settings - Fork 4k
MINOR: [Python] Array.from_buffers accepts None buffers
#49163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
MINOR: [Python] Array.from_buffers accepts None buffers
#49163
Conversation
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or See also: |
I can in fact not... I think this classifies as a minor change, but I seem to lack permissions to rename my own PR... The button for is isn't showing. Must be a GH thing. |
Array.from_buffers accepts None buffersArray.from_buffers accepts None buffers
AlenkaF
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this change is OK and would also update the DictionaryArray method docstrings. cc @raulcd what do you think?
raulcd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AlenkaF would you prefer a separate PR or should I extend this one? |
|
Please, extend this one. |
|
Done. While at it, I also saw that |
Array.from_buffers accepts None buffersArray.from_buffers accepts None buffers
Rationale for this change
Fix the docs. It seems this is a feature and not just happens to work as the code a little below even has an explicit comment:
arrow/python/pyarrow/array.pxi
Line 1347 in 0dfae70
What changes are included in this PR?
Document that
Array.from_bufferstakes alist[Buffer | None]instead of strictlylist[Buffer].Are these changes tested?
not applicable
Are there any user-facing changes?
Yes, but not in an API sense :)